C++: Fix flow out of this by reference#1900
Merged
Merged
Conversation
This class is undocumented and exposes implementation details through its `getPartialDefinition` member. It does not need to be public.
The `test_nonMemberSetA` also shows how the lack of flow through `&` is a problem for non-member getters, but that's addressed on a separate branch.
jbj
force-pushed
the
dataflow-this-by-ref
branch
from
3b538bd to
10b6935
Compare
geoffw0
approved these changes
Sep 9, 2019
geoffw0
left a comment
geoffw0
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
This was missing because there is no VariableAccess associated with it, and so it didn't fit into DefinitionByReferenceNode.
I can't help but get the feeling there are still holes. The one that springs to mind is an array access (call(callbacks[index])) but I guess TPartialDefinitionNode should cover that case.
Contributor
Author
|
Yes, there are still gaps in the coverage of this library. But this gap is actually the last one on my list of language-level problems I want to address. |
This was referenced Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a type of post-update node that allows data flow out of a
thispointer passed by reference. This was missing because there is noVariableAccessassociated with it, and so it didn't fit intoDefinitionByReferenceNode.There's a false negative in one of the tests I'm adding. This will be fixed by #1884.
I tested performance on MySQL, and it was fine.